-
Notifications
You must be signed in to change notification settings - Fork 803
added config dir parameter #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As mentioned in Jupyter-contrib/jupyter_contrib_core#1, the config-dir kwarg isn't present in notebook 4.2, and as a result doesn't make sense to add to |
|
@flying-sheep I've been thinking about this a bit recently. Although I have managed to create working versions which accept a |
|
hmm, where do runtime components get the config dir location from? is it possible that they can’t cope with custom/systemwide installations? |
I guess you mean where does the notebook server (and similar) look for config? Well, it's slightly OS-dependent, but I think in general they look at all directories in |
|
I should add, the environment variable |
|
ah, makes sense. so if i want to use |
As long as it's also set for their processes, yes, they should find it ok |
|
OK, then i’ll close this. will there be a release with the system-by-default fix in it soon? i assume the user-by-default will also mess with |
|
OK! it’s a bit awkward, but it works: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jupyter_contrib_nbextensions (well, almost. i have to patch a config file which stores the template location wrong) |
|
Ok, I have pushed 0.2.0 to pypi, conda build to follow once it's also visible on
I'm not really sure what you mean here? |
|
great! what i meant was wrong: actually i (counterintuitively) need to use with that i mean that there’s two kinds of system-wide installations on linux: manually installed stuff goes into since jupyter knows about the non- |
|
@flying-sheep great, glad you got it working 😄 Thanks for the explanation, too! So are we ok to close this PR then? |
|
yes, but it would be great to have a “true system install” option |
|
sure, though since that's OS-dependent, I think it'd have to be implemented upstream before we could use it reliably 😜 |
depends on #709 and Jupyter-contrib/jupyter_contrib_core#1